-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] rush build
and rush rebuild
don't fire prebuild
npm scripts
#830
Comments
rush build
and npm rebuild
don't fire prebuild
npm scriptsrush build
and rush rebuild
don't fire prebuild
npm scripts
This is the first I've heard of it. In our own projects, the "build" script invokes a full toolchain with its own phases, so we don't rely very much on the package.json lifecycle fields. That said, we should certainly fix this. It's probably a pretty small change. |
Out of curiousity, what does your |
|
I'd be happy to submit a PR, but I might need a little help to know where to look. |
Take a look at _getScriptToRun(). @nickpape-msft who worked on this code |
`prebuild` in package.json is not fired by `rush build` microsoft/rushstack#830
Hi. Is there any movement on this issue? Can I help somehow? It's important to me, because I prefer not to use |
I guess it is the fix to the broken link: (I understand it is outdated just that I dug down to find it so I am sharing it here) |
I must admit that I am unsure why the normal workflow does not include support for package.json lifecycle fields. EditI feel like my comment is far from being useful nor constructive I would love to know what I should do to help. I am kind of struggling to understand how to use the many features of this development stack but I have the feeling that it is a promising way of doing what I want to achieve. I would love to learn more about how to use this stack but my impression is that the documentation is not telling me all the powerful features that can be leveraged. I obviously need to use my lifecycle hooks but if I could understand what should be the workflow or workaround I would be happy to use it... |
Hey team, awesome job with Rush. We've been using Lerna on an internal monorepo for the past few months and we've had some issues. Rush seems to solve almost all of them!
I'm in the processing of replacing Lerna with Rush and I noticed the
build
/rebuild
commands don't triggerprebuild
npm script hooks we have in place. Is this a known behavior?The text was updated successfully, but these errors were encountered: