[rush] Pass down builtInPluginConfigurations #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliot-nelson
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
octogonz
reviewed
Jan 5, 2022
common/changes/@microsoft/rush/enelson-fix-builtin-option_2022-01-05-17-09.json
Outdated
Show resolved
Hide resolved
octogonz
approved these changes
Jan 5, 2022
iclanton
reviewed
Jan 5, 2022
Co-authored-by: Pete Gonzalez <4673363+octogonz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a small issue discovered while attempting to run the new
lib/start-devscript from another monorepo.Details
The
start-dev.jsscript adds in the built-in plugins so that they'll be automatically loaded by PluginManager, but the options weren't being passed down all the way. This caused issues when used in a repo other than rushstack.How it was tested