[rush] Fix an issue with adding the default options to the build and rebuild commands. #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
apostolisms,
D4N14L,
halfnibble,
octogonz and
sachinjoseph
as code owners
iclanton
force-pushed
the
fix-build-rebuild-defaults
branch
from
0841d19
to
c16093e
Compare
octogonz
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rush allows a repo maintainer to specify only the options that they specifically want to override in
common/config/rush/command-line.jsonfor the "build" and "rebuild" commands. This is broken if the maintainer wants to make build a phased command.This change fixes population of the summary, description, and other default options for build and rebuild by allowing these to apply to both bulk and phased commands and by eliminating the options that aren't shared between the two from the defaults (all of which were already set to the defaults for a bulk command).
How it was tested
Tested by removing all but the
"commandKind","name", and"phases"options fromcommon/config/rush/command-line.jsonin this branch: #3145