-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rush] restore the duration of the same operation without cache hit as telemetry data #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7008bc9
to
f261529
Compare
libraries/rush-lib/src/logic/operations/IOperationExecutionResult.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunner.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunner.ts
Outdated
Show resolved
Hide resolved
iclanton
reviewed
Sep 26, 2022
libraries/rush-lib/src/logic/operations/IOperationExecutionResult.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunner.ts
Outdated
Show resolved
Hide resolved
libraries/rush-lib/src/logic/operations/ShellOperationRunner.ts
Outdated
Show resolved
Hide resolved
common/changes/@microsoft/rush/feat-operation-metadata_2022-09-26-12-16.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
6e23717
to
5798706
Compare
Thanks @iclanton and @dmichon-msft for reviewing this. Batch of code changes according to your suggestions 🤞:
Could you take another look? |
iclanton
approved these changes
Sep 29, 2022
iclanton
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes Rush.js restores the duration of the same operation without cache hit and log
durationInSecondsWithoutCache
in operationResultDetails
.rush/temp/operation/<identifier>/state.json
which containsdurationInSecondsWithoutCache
.durationInSecondsWithoutCache
as one of the property of operationResultHow it was tested
Test with local build cache in rushstack repo steps:
"telemetryEnabled": true
in rush.jsonrm -rf common/temp/build-cache
node rush-lib/lib/start.js build -v --to tree-pattern
a.
libraries/tree-pattern/.rush/temp/operation/_phase_build/state.json
createdb.
libraries/tree-pattern/.rush/temp/rushstack+tree-pattern-_phase_build-<identifier>.log
shows.rush/temp/operation/_phase_build/state.json
is included when creating build archive.rm rf libraries/tree-pattern/.rush/temp/operation/_phase_build/state.json
node rush-lib/lib/start.js build -v --to tree-pattern
the second timea.
libraries/tree-pattern/.rush/temp/operation/_phase_build/state.json
restoredb.
common/temp/telemetry/<...>.json
recordsnonCachedDurationMs
inoperationResult
oftree-pattern