Fix rush add -p affecting all subspace projects #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william2958
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
octogonz
reviewed
Apr 17, 2024
common/changes/@microsoft/rush/will-subspace-patch-20_2024-04-17-21-20.json
Outdated
Show resolved
Hide resolved
octogonz
reviewed
Apr 17, 2024
octogonz
approved these changes
Apr 17, 2024
chengcyber
reviewed
Apr 17, 2024
| @@ -325,6 +325,7 @@ export class PackageJsonUpdater { | |||
| this._rushConfiguration | |||
| ); | |||
|
|
|||
| // console.log('adding project, updating projects: ', projects); | |||
| @@ -342,10 +343,12 @@ export class PackageJsonUpdater { | |||
| dependencyAnalyzer: DependencyAnalyzer, | |||
| options: IPackageJsonUpdaterRushAddOptions | |||
| ): Promise<IUpdateProjectOptions[]> { | |||
| const { packagesToUpdate, devDependency, peerDependency, updateOtherPackages } = options; | |||
| const { projects, packagesToUpdate, devDependency, peerDependency, updateOtherPackages } = options; | |||
There was a problem hiding this comment.
Would it be more intuitive to design the API as _updateProjects(projects, dependencyAnalyzer, { subspace, ... })?
There was a problem hiding this comment.
Never mind. It's a private function.
|
Thanks @william2958 , @octogonz , and all for a quick fix, and for your continued dedication to this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently running
rush add -p <package_name>results in every project being updated in a subspace. This fixes the issue.Details
How it was tested
Impacted documentation