[lockfile-explorer] Add version validation capability (reopened) #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Qun
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
iclanton
reviewed
Jun 12, 2024
Comment on lines
93
to
107
| await searchAndValidateDependencies( | ||
| rushConfiguration, | ||
| checkedProjects, | ||
| dependencyProject, | ||
| requiredVersions | ||
| ); | ||
| } | ||
| } else { | ||
| await checkVersionCompatibility( | ||
| shrinkwrapFileMajorVersion, | ||
| packages, | ||
| fullDependencyPath, | ||
| requiredVersions, | ||
| checkedDependencyPaths | ||
| ); |
There was a problem hiding this comment.
Seems like these results should be cached, as multiple projects can point at the same dependencies.
There was a problem hiding this comment.
The same dependency is never checked twice
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
enable some parallelization
iclanton
approved these changes
Jun 17, 2024
apps/lockfile-explorer/src/cli/explorer/ExplorerCommandLineParser.ts
Outdated
Show resolved
Hide resolved
| description: 'Show the full call stack if an error occurs while executing the tool' | ||
| }); | ||
|
|
||
| this._subspaceParameter = this.defineStringParameter({ |
There was a problem hiding this comment.
Putting this on the parser means that someone has to run lfx --subspace subspaceName start which feels awkward. lfs start --subspace subspaceName seems more ergonomic.
There was a problem hiding this comment.
This part has already been moved to Action.
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
…ser.ts Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
iclanton
approved these changes
Jun 18, 2024
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
This was referenced Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4712 was accidentally merged before approval / passing CI.
Let's use this PR to conclude the review.