Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Make sample app responsive #634

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Conversation

iseabock
Copy link
Contributor

@iseabock iseabock commented Feb 21, 2024

Motivation and Context

Sample app should be responsive

Description

Desktop and tablet resolutions are unchanged, but any screen size width < 480px will trigger a mobile view.

NOTE: The Share and Show/Hide chat history have the most changes so that they could fit in the header

Contribution Checklist

  • I have built and tested the code locally and in a deployed app
  • For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
  • This is a change for all users of this app. No code or asset is specific to my use case or my organization.
  • I didn't break any existing functionality 😄

Screenshot 2024-02-21 160438

NOTE: The screen shot above of the header demonstrates changes that are not demonstrated in the screen shots below it as these changes were done after those screen shots were taken. Please take that into consideration when looking at the rest of the shots

Screenshot 2024-02-21 145411
Screenshot 2024-02-21 145503
Screenshot 2024-02-21 145517

Screenshot 2024-02-21 145650
Screenshot 2024-02-21 145708
Screenshot 2024-02-21 145725
Screenshot 2024-02-21 145748
Screenshot 2024-02-21 145758
Screenshot 2024-02-21 145812
Screenshot 2024-02-21 151900

Copy link
Contributor

@sarah-widder sarah-widder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sarah-widder
Copy link
Contributor

Fixes #615

@npsquared
Copy link

This is awesome! I was working towards something similar but you beat me to the punch. :)
I tested this on my end and it looks good. Thank you!

@iseabock iseabock merged commit deb457c into main Feb 22, 2024
1 check passed
@iseabock iseabock deleted the NO-TASK-make-sample-responsive branch February 22, 2024 17:28
sudo-init pushed a commit to sudo-init/sample-app-chatGPT that referenced this pull request Sep 20, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
nikhilnagaraj pushed a commit to Admin-bh-Edge/Edge-Comp-Policies that referenced this pull request Oct 2, 2024
Co-authored-by: Ian Seabock (Centific Technologies Inc) <v-ianseabock@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants