Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show 'Fix in VS Code' link for MS orgs #14

Merged
merged 2 commits into from
May 15, 2023

Conversation

EasyRhinoMSFT
Copy link
Contributor

This change uses the Identities api to get the org's backing AAD tenant, if any. The 'Fix in VS Code' link will only be shown for orgs backed by the MS corp tenant.

@EasyRhinoMSFT EasyRhinoMSFT requested a review from 50Wliu May 14, 2023 21:47
@EasyRhinoMSFT EasyRhinoMSFT merged commit c46f4de into main May 15, 2023
@nwcm
Copy link
Contributor

nwcm commented May 17, 2023

@EasyRhinoMSFT the Fin in VS Code link still appears for Azure DevOps projects even if they are outside of the MS corp tenant.

version 0.4.11 is installed

@EasyRhinoMSFT
Copy link
Contributor Author

Yes there was some kind of issue with the prod deployment (dev works fine) that left the extension in a broken state. I decided to roll it back and am now investigating with the help of the ADO extensions team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants