Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failures #81

Closed
ghost opened this issue Jan 22, 2016 · 2 comments
Closed

Unit test failures #81

ghost opened this issue Jan 22, 2016 · 2 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jan 22, 2016

There are several test failures. Console output attached:

sarif-sdk-test-errors.txt

Not clear how many distinct errors this represents. Will open separate issues as appropriate.

@ghost ghost assigned michaelcfanning Jan 22, 2016
@michaelcfanning
Copy link
Member

There's only a single test failure in this output. The other output is due to the unit tests comprehensive negative condition testing. It's not easy to extract relevant information for real failures, we should try to clean it up. If you examine the final test summary, you'll see the actual # of failures. Search on [FAIL] to get the real thing.

Microsoft.CodeAnalysis.Sarif.Driver.Sdk.AnalyzeCommandBaseTests.UnauthorizedAccessExceptionCreatingSarifLog [FAIL]

Sarif.Driver.UnitTests Total: 17, Errors: 0, Failed: 1, Skipped: 0, Time: 1.107s

The problem here is likely that you are running with admin privileges, which is allowing you to create log files where tests expect to get blocked. We can change the test code to provide a more reliable mechanism to raise UnauthorizedAccessException

@ghost
Copy link
Author

ghost commented Jan 22, 2016

@michaelcfanning fixed this in #85.

(Michael, GitHub didn't auto-resolve it because you typoed the title of the PR ("Resolves #181" instead of "Resolves #81").

@ghost ghost closed this as completed Jan 22, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant