Make sure all tests fail even running under admin privileges. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcfanning
added a commit
that referenced
this pull request
Jan 22, 2016
Make sure all tests fail even running under admin privileges.
| @@ -308,10 +308,10 @@ public void IOExceptionRaisedCreatingSarifLog() | |||
| [Fact] | |||
| public void UnauthorizedAccessExceptionCreatingSarifLog() | |||
| { | |||
| string path = Environment.GetFolderPath(Environment.SpecialFolder.Windows); | |||
| string path = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData); | |||
| path = Path.Combine(path, Guid.NewGuid().ToString()); | |||
There was a problem hiding this comment.
Why does this work? I'd've expected that an admin could create a file anywhere.
There was a problem hiding this comment.
Oh, I see. I had to look at the whole file to understand that the failure happens when you try to persist to a file that already exists. And the change to ApplicationData is just because that's a better place than littering Windows.
|
👍 |
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #81. @lgolding
Larry, note in the meantime that you can run tests as non-admin to verify. This change also adds explicit platform property to build step.