Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded merge #2026

Merged
merged 16 commits into from
Oct 29, 2020
Merged

Multithreaded merge #2026

merged 16 commits into from
Oct 29, 2020

Conversation

michaelcfanning
Copy link
Member

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2020

This pull request introduces 3 alerts when merging 3c73686 into bb4dee3 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Container contents are never accessed #Closed

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2020

This pull request introduces 3 alerts when merging 128f7d4 into bb4dee3 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Container contents are never accessed #Closed

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2020

This pull request introduces 3 alerts when merging c93a158 into f0fd0c9 - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Container contents are never accessed #Closed

@lgtm-com
Copy link

lgtm-com bot commented Oct 26, 2020

This pull request introduces 3 alerts when merging ec4e414 into 018374f - view on LGTM.com

new alerts:

  • 2 for Useless assignment to local variable
  • 1 for Container contents are never accessed #Closed

@eddynaka
Copy link
Collaborator

eddynaka commented Oct 26, 2020

        RunTest("NoInputFiles.sarif");

@michaelcfanning , what would be the expected input for this? #Closed


Refers to: src/Test.UnitTests.Sarif.Multitool.Library/MergeCommandTests.cs:40 in c9f1ae6. [](commit_id = c9f1ae6, deletion_comment = False)

@eddynaka
Copy link
Collaborator

        RunTest("NoInputFiles.sarif");

I think I already solved my question. No inputs at all. Thanks


In reply to: 716857042 [](ancestors = 716857042)


Refers to: src/Test.UnitTests.Sarif.Multitool.Library/MergeCommandTests.cs:40 in c9f1ae6. [](commit_id = c9f1ae6, deletion_comment = False)

@eddynaka eddynaka self-assigned this Oct 29, 2020
@eddynaka eddynaka requested a review from cfaucon October 29, 2020 14:05
@michaelcfanning michaelcfanning merged commit 9abc951 into master Oct 29, 2020
@michaelcfanning michaelcfanning deleted the multithreaded-merge branch October 29, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants