Optimize partitioned logs by removing not relevant rules #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 55b1929 into cfb4f9b - view on LGTM.com new alerts:
|
eddynaka
reviewed
Jun 16, 2021
| return null; | ||
| } | ||
|
|
||
| var referencedRulesByIndex = new Dictionary<ReportingDescriptor, int>(); |
eddynaka
reviewed
Jun 16, 2021
| var referencedRulesByIndex = new Dictionary<ReportingDescriptor, int>(); | ||
| int index = 0; | ||
|
|
||
| foreach (Result result in results) |
…icrosoft/sarif-sdk into users/yongyan-gh/fileworkitems
eddynaka
reviewed
Jun 16, 2021
src/Sarif/ExtensionMethods.cs
Outdated
| @@ -37,6 +37,11 @@ public static IEnumerable<SarifLog> Split(this SarifLog sarifLog, SplittingStrat | |||
| partitionFunction = (result) => result.Run.GetHashCode().ToString(); | |||
| break; | |||
| } | |||
| case SplittingStrategy.PerRunPerTarget: | |||
| { | |||
| partitionFunction = (result) => result.Locations.FirstOrDefault().PhysicalLocation.ArtifactLocation.Uri.OriginalString; | |||
eddynaka
reviewed
Jun 16, 2021
| @@ -177,8 +177,6 @@ public virtual IReadOnlyList<SarifLog> SplitLogFile(SarifLog sarifLog) | |||
| this.FilingResult = FilingResult.None; | |||
| this.FiledWorkItems = new List<WorkItemModel>(); | |||
|
|
|||
| sarifLog = sarifLog ?? throw new ArgumentNullException(nameof(sarifLog)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.