Add baseline option for analyze command #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 69728b4 into 744db99 - view on LGTM.com new alerts:
|
eddynaka
reviewed
Jul 9, 2021
| using (var reader = new JsonTextReader(new StreamReader(fileSystem.FileOpenRead(options.BaselineSarifFile)))) | ||
| { | ||
| baselineFile = serializer.Deserialize<SarifLog>(reader); | ||
| } |
There was a problem hiding this comment.
you can replace this by:
baselineFile = SarifLog.Load(optons.BaselineSarifFile)
There was a problem hiding this comment.
Can I inject a mock IFileSystem to SarifLog for test cases?
eddynaka
reviewed
Jul 9, 2021
| using (var reader = new JsonTextReader(new StreamReader(fileSystem.FileOpenRead(options.OutputFilePath)))) | ||
| { | ||
| currentSarifLog = serializer.Deserialize<SarifLog>(reader); | ||
| } |
There was a problem hiding this comment.
use this:
currentSarifLog = SarifLog.Load(xyz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.