Skip to content

Commit

Permalink
Python: Update 00-getting-started.ipynb (#2766)
Browse files Browse the repository at this point in the history
deployment name is required instead of
kernel.add_chat_service("chat_completion",
AzureChatCompletion("gpt-35-turbo", endpoint, api_key))

Fixes #2772

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  For notebook to work.
  2. What problem does it solve?
  current fails with error deployment not exist.
  3. What scenario does it contribute to?
  Getting started
  7. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Just replaced hardcoded deployment name to use deployment parameter
from .env file! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

Co-authored-by: Lee Miller <lemiller@microsoft.com>
  • Loading branch information
vivekgarudi and lemillermicrosoft committed Sep 13, 2023
1 parent 34456aa commit 2b94161
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/notebooks/00-getting-started.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"\n",
"deployment, api_key, endpoint = sk.azure_openai_settings_from_dot_env()\n",
"\n",
"kernel.add_chat_service(\"chat_completion\", AzureChatCompletion(\"gpt-35-turbo\", endpoint, api_key))\n"
"kernel.add_chat_service(\"chat_completion\", AzureChatCompletion(deployment, endpoint, api_key))\n"
]
},
{
Expand Down

0 comments on commit 2b94161

Please sign in to comment.