Python: Update 00-getting-started.ipynb #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployment name is required instead of kernel.add_chat_service("chat_completion", AzureChatCompletion("gpt-35-turbo", endpoint, api_key))
github-actions
bot
changed the title
lemillermicrosoft
approved these changes
Sep 13, 2023
alexchaomander
approved these changes
Sep 13, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
deployment name is required instead of
kernel.add_chat_service("chat_completion",
AzureChatCompletion("gpt-35-turbo", endpoint, api_key))
Fixes microsoft#2772
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
1. Why is this change required?
For notebook to work.
2. What problem does it solve?
current fails with error deployment not exist.
3. What scenario does it contribute to?
Getting started
7. If it fixes an open issue, please link to the issue here.
-->
### Description
<!-- Just replaced hardcoded deployment name to use deployment parameter
from .env file! -->
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 馃槃
Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployment name is required instead of kernel.add_chat_service("chat_completion", AzureChatCompletion("gpt-35-turbo", endpoint, api_key))
Fixes #2772
Motivation and Context
Description
Contribution Checklist