Skip to content

Commit

Permalink
.Net: Focus CI on .NET 8 SDK (#5802)
Browse files Browse the repository at this point in the history
This is about which SDK is used, not which target framework is used.
.NET 7 is EOL in May. .NET 6 is EOL in Nov.

---------

Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
  • Loading branch information
stephentoub and crickman committed Apr 9, 2024
1 parent a8bf2b6 commit 71221a6
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 17 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/dotnet-build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,8 @@ jobs:
fail-fast: false
matrix:
include:
- { dotnet: "6.0-jammy", os: "ubuntu", configuration: Debug }
- { dotnet: "7.0-jammy", os: "ubuntu", configuration: Release }
- { dotnet: "8.0-jammy", os: "ubuntu", configuration: Release }
- { dotnet: "6.0", os: "windows", configuration: Release }
- {
dotnet: "7.0",
os: "windows",
configuration: Debug,
integration-tests: true,
}
- { dotnet: "8.0", os: "windows", configuration: Debug, integration-tests: true, }
- { dotnet: "8.0", os: "windows", configuration: Release }

runs-on: ubuntu-latest
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/dotnet-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- { os: ubuntu-latest, dotnet: '6.0', configuration: Debug }
- { os: ubuntu-latest, dotnet: '6.0', configuration: Release }
- { os: ubuntu-latest, dotnet: '7.0', configuration: Release }
- { os: ubuntu-latest, dotnet: '8.0', configuration: Debug }
- { os: ubuntu-latest, dotnet: '8.0', configuration: Release }

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -68,7 +66,7 @@ jobs:
matrix:
os: [windows-latest]
configuration: [Release, Debug]
dotnet-version: ['7.0.x']
dotnet-version: ['8.0.x']
runs-on: ${{ matrix.os }}
env:
NUGET_CERT_REVOCATION_MODE: offline
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/dotnet-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ jobs:
fail-fast: false
matrix:
include:
#- { dotnet: '6.0', configuration: Release, os: ubuntu-latest }
#- { dotnet: '7.0', configuration: Release, os: ubuntu-latest }
- { dotnet: '8.0', configuration: Release, os: ubuntu-latest }

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dotnet-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
uses: actions/setup-dotnet@v4
if: ${{ github.event_name != 'pull_request' }}
with:
dotnet-version: 6.0.x
dotnet-version: 8.0.x

- name: Find projects
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/SemanticKernel.Abstractions/Kernel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Microsoft.SemanticKernel;
/// </remarks>
public sealed class Kernel
{
/// <summary>Key used by KernelBuilder to store type information into the service provider.</summary>
/// <summary>Key used by <see cref="IKernelBuilder"/> to store type information into the service provider.</summary>
internal const string KernelServiceTypeToKeyMappings = nameof(KernelServiceTypeToKeyMappings);

/// <summary>Dictionary containing ambient data stored in the kernel, lazily-initialized on first access.</summary>
Expand Down

0 comments on commit 71221a6

Please sign in to comment.