Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Rename 'Skills' -> 'Plugins' #2119

Closed
9 of 10 tasks
nacharya1 opened this issue Jul 21, 2023 · 1 comment
Closed
9 of 10 tasks

.Net: Rename 'Skills' -> 'Plugins' #2119

nacharya1 opened this issue Jul 21, 2023 · 1 comment
Assignees
@markwallace-microsoft
Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Milestone
v1.0.0.RC1

Comments

@nacharya1
Copy link
Contributor

nacharya1 commented Jul 21, 2023 •
edited by markwallace-microsoft

Tasks
Beta Give feedback
  6. .Net: Skill->Plugins: Update notebooks #2970
    .NET sk team issue
    dmytrostruk
  8. .Net: Skill->Plugins: update documentation #2127
    .NET docs and tests sk team issue
    matthewbolanos
  9. .Net: Rename ImportXXXPlugins methods to ImportXXXFunctions for GRPC #2943
    .NET PR: breaking change kernel
    markwallace-microsoft
  10. .Net: Rename ImportXXXPlugins methods to ImportXXXFunctions #2937
    .NET PR: breaking change kernel kernel.core
    markwallace-microsoft
@nacharya1 nacharya1 changed the title remove skills concept and use plugins instead .net: remove skills concept and use plugins instead Jul 21, 2023
@shawncal shawncal changed the title .net: remove skills concept and use plugins instead .Net: Rename 'Skills' to 'Plugins' Jul 21, 2023
@shawncal shawncal self-assigned this Jul 21, 2023
@shawncal shawncal changed the title .Net: Rename 'Skills' to 'Plugins' .Net: Rename 'Skills' -> 'Plugins' Jul 21, 2023
@evchaki evchaki added .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) labels Jul 31, 2023
This was referenced Aug 1, 2023
Closed
Merged
@nacharya1 nacharya1 added this to the R3 : Cycle 2 milestone Aug 4, 2023
@lemillermicrosoft lemillermicrosoft modified the milestones: R3 : Cycle 2, v1 Sep 12, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 18, 2023
@markwallace-microsoft
.Net: Rename 'Skills' -> 'Plugins' - Part 1 (#2854)
c10f7c4 
### Motivation and Context

Rename `Skills` to `Plugins`. First sub task from
#2119.

### Description

This is the first PR

1. Move Core, Document, MsGraph and Web skill projects to a new
`Plugins` folder
2. Update Core, Document, MsGraph and Web projects to use `Plugins`
instead of `Skills` in assembly names, namespace, class names
3. Extract text from `Skills.UnitTests` and create new
`Plugins.UnitTests` project

Solution Explorer:

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/16dd8146-d8a0-44e3-8995-894afb644e09)

File Explorer:

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/1aef0bd9-ac54-492f-8725-eac0d3e6db86)

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2023
@markwallace-microsoft
.Net: Rename 'Skills' -> 'Plugins' - Part 2 (#2863)
99b5ed8 
### Motivation and Context

Rename Skills to Functions for GRPC and OpenAPI packages. Second sub
task from #2119.

### Description

1. Move GRPC and OpenAPI projects to a new `Functions` folder on disk
and in the solution
1. Update GRPC and OpenAPI projects to use Functions instead of Skills
in assembly names, namespace, class names
1. Rename Skills.UnitTests to Functions.UnitTests project

Solution Explorer

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/ebc4562a-4a45-435f-a06d-edd611cdfb03)

### Contribution Checklist

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 21, 2023
@markwallace-microsoft
.Net: Rename 'Skills' -> 'Plugins' - Part 3 (#2904)
b3c5ee0 
### Motivation and Context

Rename Skills to Functions for SK core and abstractions packages. Third
sub task from #2119.

### Description

- Remove the `Microsoft.SemanticKernel.SkillDefinition` namespace and
promote classes previously contained to `Microsoft.SemanticKernel`, this
is to reduce the number of `using`s that client code required.
 - Rename variable/function names using skillName to pluginName.
- Rename skill collection interfaces/classes to use function collection.
- Leave some obsolete methods/properties to help with the upgrade from
earlier releases.

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@markwallace-microsoft
Copy link
Member

Done

SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this issue Nov 1, 2023
@markwallace-microsoft @SOE-YoungS
.Net: Rename 'Skills' -> 'Plugins' - Part 1 (microsoft#2854)
07cbb79 
### Motivation and Context

Rename `Skills` to `Plugins`. First sub task from
microsoft#2119.

### Description

This is the first PR

1. Move Core, Document, MsGraph and Web skill projects to a new
`Plugins` folder
2. Update Core, Document, MsGraph and Web projects to use `Plugins`
instead of `Skills` in assembly names, namespace, class names
3. Extract text from `Skills.UnitTests` and create new
`Plugins.UnitTests` project

Solution Explorer:

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/16dd8146-d8a0-44e3-8995-894afb644e09)

File Explorer:

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/1aef0bd9-ac54-492f-8725-eac0d3e6db86)

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this issue Nov 1, 2023
@markwallace-microsoft @SOE-YoungS
.Net: Rename 'Skills' -> 'Plugins' - Part 2 (microsoft#2863)
037d4f7 
### Motivation and Context

Rename Skills to Functions for GRPC and OpenAPI packages. Second sub
task from microsoft#2119.

### Description

1. Move GRPC and OpenAPI projects to a new `Functions` folder on disk
and in the solution
1. Update GRPC and OpenAPI projects to use Functions instead of Skills
in assembly names, namespace, class names
1. Rename Skills.UnitTests to Functions.UnitTests project

Solution Explorer

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/ebc4562a-4a45-435f-a06d-edd611cdfb03)

### Contribution Checklist

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this issue Nov 1, 2023
@markwallace-microsoft @SOE-YoungS
.Net: Rename 'Skills' -> 'Plugins' - Part 3 (microsoft#2904)
a971b29 
### Motivation and Context

Rename Skills to Functions for SK core and abstractions packages. Third
sub task from microsoft#2119.

### Description

- Remove the `Microsoft.SemanticKernel.SkillDefinition` namespace and
promote classes previously contained to `Microsoft.SemanticKernel`, this
is to reduce the number of `using`s that client code required.
 - Rename variable/function names using skillName to pluginName.
- Rename skill collection interfaces/classes to use function collection.
- Leave some obsolete methods/properties to help with the upgrade from
earlier releases.

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
v1.0.0.RC1
Development

No branches or pull requests
5 participants
@lemillermicrosoft @shawncal @evchaki @nacharya1 @markwallace-microsoft