Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Rename 'Skills' -> 'Plugins' - Part 1 #2854

Conversation

markwallace-microsoft
Copy link
Member

@markwallace-microsoft markwallace-microsoft commented Sep 18, 2023

Motivation and Context

Rename Skills to Plugins. First sub task from #2119.

Description

This is the first PR

  1. Move Core, Document, MsGraph and Web skill projects to a new Plugins folder
  2. Update Core, Document, MsGraph and Web projects to use Plugins instead of Skills in assembly names, namespace, class names
  3. Extract text from Skills.UnitTests and create new Plugins.UnitTests project

Solution Explorer:
image

File Explorer:
image

Contribution Checklist

@markwallace-microsoft markwallace-microsoft added the PR: breaking change Pull requests that introduce breaking changes label Sep 18, 2023
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Sep 18, 2023
@shawncal shawncal added docs and tests Improvements or additions to documentation samples labels Sep 18, 2023
@markwallace-microsoft markwallace-microsoft marked this pull request as ready for review September 18, 2023 13:08
@markwallace-microsoft markwallace-microsoft requested a review from a team as a code owner September 18, 2023 13:08
Copy link
Contributor

@hario90 hario90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - there's one csproj that looks like it needs to be removed and I can approve after the python notebooks are removed.

Copy link
Contributor

@hario90 hario90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reviewing old changes - looks like the notebook changes got removed.

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Sep 18, 2023
Merged via the queue into microsoft:main with commit c10f7c4 Sep 18, 2023
23 checks passed
@markwallace-microsoft markwallace-microsoft deleted the users/markwallace/skills-plugins-part1 branch September 18, 2023 19:04
SOE-YoungS pushed a commit to SOE-YoungS/semantic-kernel that referenced this pull request Nov 1, 2023
### Motivation and Context

Rename `Skills` to `Plugins`. First sub task from
microsoft#2119.

### Description

This is the first PR

1. Move Core, Document, MsGraph and Web skill projects to a new
`Plugins` folder
2. Update Core, Document, MsGraph and Web projects to use `Plugins`
instead of `Skills` in assembly names, namespace, class names
3. Extract text from `Skills.UnitTests` and create new
`Plugins.UnitTests` project

Solution Explorer:

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/16dd8146-d8a0-44e3-8995-894afb644e09)

File Explorer:

![image](https://github.com/microsoft/semantic-kernel/assets/127216156/1aef0bd9-ac54-492f-8725-eac0d3e6db86)

### Contribution Checklist

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 馃槃
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs and tests Improvements or additions to documentation kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: breaking change Pull requests that introduce breaking changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants