.Net: PromptTemplateConfig and IPromptTemplate namesapce refactor #3173
Comments
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
This was referenced Oct 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 16, 2023
#3174) ### Motivation and Context Resolves: #3173 ### Description - Move `IPromptTemplate` to namespace `Microsoft.SemanticKernel.TemplateEngine` - Move `PromptTemplate` and `PromptTemplateConfig` to namespace `Microsoft.SemanticKernel.TemplateEngine` - Eliminate `Microsoft.SemanticKernel.SemanticFunctions` namespace - Remove `SemanticFunctionConfig` ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this issue
Nov 1, 2023
microsoft#3174) ### Motivation and Context Resolves: microsoft#3173 ### Description - Move `IPromptTemplate` to namespace `Microsoft.SemanticKernel.TemplateEngine` - Move `PromptTemplate` and `PromptTemplateConfig` to namespace `Microsoft.SemanticKernel.TemplateEngine` - Eliminate `Microsoft.SemanticKernel.SemanticFunctions` namespace - Remove `SemanticFunctionConfig` ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extracted from #3151
(11)
Microsoft.SemanticKernel.SemanticFunctions contains types like PromptTemplateConfig and IPromptTemplate, while Microsoft.SemanticKernel.TemplateEngine contains IPromptTemplateEngine. Why are these separate namespaces?
The text was updated successfully, but these errors were encountered: