Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add Support for "dall-e-3" Model in OpenAIImageGeneration Class #3435

Closed
Nurgo opened this issue Nov 9, 2023 · 6 comments · Fixed by #6623
Closed

.Net: Add Support for "dall-e-3" Model in OpenAIImageGeneration Class #3435

Nurgo opened this issue Nov 9, 2023 · 6 comments · Fixed by #6623
Assignees
Labels
.NET Issue or Pull requests regarding .NET code

Comments

@Nurgo
Copy link

Nurgo commented Nov 9, 2023

Hi,

I propose we add support for the "dall-e-3" model within the OpenAIImageGeneration class. The integration seems straightforward and the benefit to the users would be substantial, allowing them to utilize the latest in image generation technology.

Proposed Change:

  • Update the OpenAIImageGeneration class to include "dall-e-3" model support.
  • Introduce a "modelId" parameter in the constructor to select the desired image generation model, similar to how it is currently handled for text generation models in the library.

This enhancement would allow for seamless use of "dall-e-3" for image generation tasks, maintaining the library's relevance and utility.

Thank you for considering this request.

@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Nov 9, 2023
@Alerinos
Copy link

@Nurgo Have you found a way to use SK and Dalle 3?

@Nurgo
Copy link
Author

Nurgo commented Nov 29, 2023

@Alerinos Not yet. There's a pull request #3523 from @xbotter , but it's been awaiting code review for a few weeks.

@Alerinos
Copy link

@Nurgo
Thanks for the information. I found an alternative, here is the support and it's ready.
https://github.com/betalgo/openai

@Nurgo
Copy link
Author

Nurgo commented Nov 29, 2023

@Alerinos Thanks for the information.

@matthewbolanos matthewbolanos added ai connector Anything related to AI connectors and removed enhancement labels Jan 2, 2024
@markwallace-microsoft
Copy link
Member

All .Net issues prior to 1-Dec-2023 are being closed. Please re-open, if this issue is still relevant to the .Net Semantic Kernel 1.x release. In the future all issues that are inactive for more than 90 days will be labelled as 'stale' and closed 14 days later.

@markwallace-microsoft markwallace-microsoft added auto-closed Automatically closed and removed .NET Issue or Pull requests regarding .NET code ai connector Anything related to AI connectors labels Mar 12, 2024
@Nurgo
Copy link
Author

Nurgo commented Apr 2, 2024

This problem doesn't seem to have been solved, as OpenAITextToImageService still doesn't support Dall-E3. Can we re-open the issue?

@stephentoub stephentoub reopened this Jun 6, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage and removed auto-closed Automatically closed labels Jun 6, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Jun 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
…#6623)

### Motivation and Context
Closes #3435 

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
Archived in project
6 participants