-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Add Support for 'dall-e-3' Model in OpenAIImageGeneration Class #6623
Merged
markwallace-microsoft
merged 7 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/issue_3435
Jun 12, 2024
Merged
.Net: Add Support for 'dall-e-3' Model in OpenAIImageGeneration Class #6623
markwallace-microsoft
merged 7 commits into
microsoft:main
from
markwallace-microsoft:users/markwallace/issue_3435
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
documentation
labels
Jun 7, 2024
github-actions
bot
changed the title
Add Support for 'dall-e-3' Model in OpenAIImageGeneration Class
.Net: Add Support for 'dall-e-3' Model in OpenAIImageGeneration Class
Jun 7, 2024
markwallace-microsoft
force-pushed
the
users/markwallace/issue_3435
branch
from
June 7, 2024 18:18
60f3185
to
b4947a1
Compare
stephentoub
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a stop-gap and that very soon this will all be rewritten on top of the new OpenAI nupkg?
Yes, that's correct |
SergeyMenshykh
approved these changes
Jun 10, 2024
RogerBarreto
approved these changes
Jun 10, 2024
markwallace-microsoft
force-pushed
the
users/markwallace/issue_3435
branch
from
June 12, 2024 08:54
8391d62
to
1b26d68
Compare
dmytrostruk
approved these changes
Jun 12, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…microsoft#6623) ### Motivation and Context Closes microsoft#3435 <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #3435
Description
Contribution Checklist