Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function calling stepwise planner fails to parse yaml prompt template #4249

Closed
alliscode opened this issue Dec 13, 2023 · 0 comments
Closed

Function calling stepwise planner fails to parse yaml prompt template #4249

alliscode opened this issue Dec 13, 2023 · 0 comments
Assignees
@alliscode
Labels
.NET Issue or Pull requests regarding .NET code release blocker Issue that must be fixed before the next release v1.0.1 Required for the Semantic Kernel v1.0.1 release

Comments

@alliscode
Copy link
Member

Describe the bug

The function calling stepwise planner fails to parse the yaml template because it is missing the required serviceId. This is resolved with this PR: #4219

Platform

  • OS: [e.g. Windows, Mac]
  • IDE: [e.g. Visual Studio, VS Code]
  • Language: [e.g. C#, Python]
  • Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Add any other context about the problem here.
@alliscode alliscode self-assigned this Dec 13, 2023
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels Dec 13, 2023
@github-actions github-actions bot changed the title Function calling stepwise planner fails to parse yaml prompt template .Net: Function calling stepwise planner fails to parse yaml prompt template Dec 13, 2023
@github-actions github-actions bot changed the title .Net: Function calling stepwise planner fails to parse yaml prompt template Python: Function calling stepwise planner fails to parse yaml prompt template Dec 13, 2023
@alliscode alliscode added v1.0.1 Required for the Semantic Kernel v1.0.1 release and removed triage python Pull requests for the Python Semantic Kernel labels Dec 13, 2023
@alliscode alliscode mentioned this issue Dec 13, 2023
Merged
4 tasks
@alliscode alliscode changed the title Python: Function calling stepwise planner fails to parse yaml prompt template Function calling stepwise planner fails to parse yaml prompt template Dec 13, 2023
@markwallace-microsoft markwallace-microsoft added the release blocker Issue that must be fixed before the next release label Dec 14, 2023
github-merge-queue bot pushed a commit that referenced this issue Dec 14, 2023
@alliscode
.Net: Function calling stepwise planner integration tests in pipeline (…
73a3323 
…#4219)

### Motivation and Context

We have been ignoring our integration tests for the function calling
stepwise planner because we did not have a function calling model setup
to be used in the test pipeline. This PR adds the configuration needed
to enable the planner tests (only) to use the newly deployed function
calling models.
I have created new configurations for the planner tests so as to not
disturb the existing tests by changing the model. This is mainly to
avoid any disruptions or slowdowns in the testing process as we get
ready for the V1 release.

Resolved issue #4249

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Ben Thomas <bentho@microsoft.com>
zengin pushed a commit to microsoftgraph/semantic-kernel that referenced this issue Jan 5, 2024
@alliscode @zengin
.Net: Function calling stepwise planner integration tests in pipeline (…
dee72c6 
…microsoft#4219)

### Motivation and Context

We have been ignoring our integration tests for the function calling
stepwise planner because we did not have a function calling model setup
to be used in the test pipeline. This PR adds the configuration needed
to enable the planner tests (only) to use the newly deployed function
calling models.
I have created new configurations for the planner tests so as to not
disturb the existing tests by changing the model. This is mainly to
avoid any disruptions or slowdowns in the testing process as we get
ready for the V1 release.

Resolved issue microsoft#4249

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Ben Thomas <bentho@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alliscode alliscode

Labels
.NET Issue or Pull requests regarding .NET code release blocker Issue that must be fixed before the next release v1.0.1 Required for the Semantic Kernel v1.0.1 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alliscode @shawncal @markwallace-microsoft