-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Function calling stepwise planner integration tests in pipeline #4219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
labels
Dec 13, 2023
github-actions
bot
changed the title
Function calling tests
.Net: Function calling tests
Dec 13, 2023
glahaye
approved these changes
Dec 13, 2023
alliscode
changed the title
.Net: Function calling tests
.Net: Function calling stepwise planner integration tests in pipeline
Dec 13, 2023
markwallace-microsoft
added
the
v1.0.1
Required for the Semantic Kernel v1.0.1 release
label
Dec 13, 2023
markwallace-microsoft
approved these changes
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 14, 2023
markwallace-microsoft
approved these changes
Dec 14, 2023
zengin
pushed a commit
to microsoftgraph/semantic-kernel
that referenced
this pull request
Jan 5, 2024
…microsoft#4219) ### Motivation and Context We have been ignoring our integration tests for the function calling stepwise planner because we did not have a function calling model setup to be used in the test pipeline. This PR adds the configuration needed to enable the planner tests (only) to use the newly deployed function calling models. I have created new configurations for the planner tests so as to not disturb the existing tests by changing the model. This is mainly to avoid any disruptions or slowdowns in the testing process as we get ready for the V1 release. Resolved issue microsoft#4249 - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Ben Thomas <bentho@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have been ignoring our integration tests for the function calling stepwise planner because we did not have a function calling model setup to be used in the test pipeline. This PR adds the configuration needed to enable the planner tests (only) to use the newly deployed function calling models.
I have created new configurations for the planner tests so as to not disturb the existing tests by changing the model. This is mainly to avoid any disruptions or slowdowns in the testing process as we get ready for the V1 release.
Resolved issue #4249