Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Function calling stepwise planner integration tests in pipeline #4219

Merged
merged 10 commits into from
Dec 14, 2023

Conversation

alliscode
Copy link
Member

@alliscode alliscode commented Dec 13, 2023

Motivation and Context

We have been ignoring our integration tests for the function calling stepwise planner because we did not have a function calling model setup to be used in the test pipeline. This PR adds the configuration needed to enable the planner tests (only) to use the newly deployed function calling models.
I have created new configurations for the planner tests so as to not disturb the existing tests by changing the model. This is mainly to avoid any disruptions or slowdowns in the testing process as we get ready for the V1 release.

Resolved issue #4249

@alliscode alliscode requested a review from a team as a code owner December 13, 2023 00:43
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Dec 13, 2023
@github-actions github-actions bot changed the title Function calling tests .Net: Function calling tests Dec 13, 2023
@alliscode alliscode changed the title .Net: Function calling tests .Net: Function calling stepwise planner integration tests in pipeline Dec 13, 2023
@markwallace-microsoft markwallace-microsoft added the v1.0.1 Required for the Semantic Kernel v1.0.1 release label Dec 13, 2023
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Dec 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 14, 2023
@alliscode alliscode added this pull request to the merge queue Dec 14, 2023
Merged via the queue into microsoft:main with commit 73a3323 Dec 14, 2023
18 checks passed
@alliscode alliscode deleted the function-calling-tests branch December 14, 2023 17:25
zengin pushed a commit to microsoftgraph/semantic-kernel that referenced this pull request Jan 5, 2024
…microsoft#4219)

### Motivation and Context

We have been ignoring our integration tests for the function calling
stepwise planner because we did not have a function calling model setup
to be used in the test pipeline. This PR adds the configuration needed
to enable the planner tests (only) to use the newly deployed function
calling models.
I have created new configurations for the planner tests so as to not
disturb the existing tests by changing the model. This is mainly to
avoid any disruptions or slowdowns in the testing process as we get
ready for the V1 release.

Resolved issue microsoft#4249

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Ben Thomas <bentho@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code v1.0.1 Required for the Semantic Kernel v1.0.1 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants