-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Filters use cases to be supported before making the feature non-experimental #5436
Comments
For Approving function calls: Not sure I completely understand the use case for User vs Developer. In terms of what happens after a 'cancellation' there should be higher flexibility. There are two places for filters Pre function invocation and post invocation.
@matthewbolanos , does that make sense ? |
I created a second issue to track the need for filters at the automatic function call level here: #5470 |
In terms of prioritization of samples, I would demonstrate filters in the following order:
|
@matthewbolanos I've already added text moderation together with Prompt Shields in the same PR. But it uses Azure AI Content Safety service instead of OpenAI moderation endpoint: We can extend this demo app later when OpenAI text moderation connector will be implemented. Let me know what you think about it. |
Lowered the priority of the text classification example per your comment |
Hi @dmytrostruk, there are 3 top items I have from customer requests to add to this: |
|
|
Example of PII detection: #6171 |
Example of text summarization and translation evaluation: #6262 |
Example of FrugalGPT: #6815 |
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Related: #5436 Kernel and connectors have out-of-the-box telemetry to capture key information, which is available during requests. In most cases this telemetry should be enough to understand how the application behaves. This example contains the same telemetry recreated using Filters. This should allow to extend existing telemetry if needed with additional information and have the same set of logging messages for custom connectors. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Tasks
To make filters non-experimental, the following user stories should be met:
Additionally, thought should be considered to make applying filters more easily. These are likely extensions, so they should not be blocking for making filters non-experimental:
The text was updated successfully, but these errors were encountered: