-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Added function invocation approval demo app #6109
Merged
dmytrostruk
merged 10 commits into
microsoft:main
from
dmytrostruk:function-invocation-approval-example
May 8, 2024
Merged
.Net: Added function invocation approval demo app #6109
dmytrostruk
merged 10 commits into
microsoft:main
from
dmytrostruk:function-invocation-approval-example
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
westey-m
approved these changes
May 3, 2024
dotnet/samples/Demos/FunctionInvocationApproval/Options/OpenAIOptions.cs
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
May 8, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR contains demo console application that shows how to use function invocation filter to invoke function only if such operation was approved. If function invocation was rejected, the result will contain an information about this, so LLM can react accordingly. Application uses a `SoftwareBuilderPlugin` that allows to build a software by following main development stages: collection of requirements, design, implementation, testing and deployment. Each step can be approved or rejected. Based on that, LLM will decide how to proceed. One of the possible outputs: ``` ==================== Function name: CollectRequirements Plugin name: SoftwareBuilderPlugin Arguments: N/A Approve invocation? (yes/no) yes Collecting requirements... ==================== Function name: Design Plugin name: SoftwareBuilderPlugin Arguments: requirements: Requirements Approve invocation? (yes/no) yes Designing based on: Requirements ==================== Function name: Implement Plugin name: SoftwareBuilderPlugin Arguments: requirements: Requirements design: Design Approve invocation? (yes/no) no I'm sorry, but the implementation phase was rejected. It seems there might be an issue with the requirements or design. Let's review them and try again. ``` ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR contains demo console application that shows how to use function invocation filter to invoke function only if such operation was approved. If function invocation was rejected, the result will contain an information about this, so LLM can react accordingly. Application uses a
SoftwareBuilderPlugin
that allows to build a software by following main development stages: collection of requirements, design, implementation, testing and deployment. Each step can be approved or rejected. Based on that, LLM will decide how to proceed.One of the possible outputs:
Description
Contribution Checklist