Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Add Grounding Skill to Samples #1064

Merged
merged 75 commits into from
Jun 15, 2023
Merged

Python: Add Grounding Skill to Samples #1064

merged 75 commits into from
Jun 15, 2023

Conversation

riedgar-ms
Copy link
Contributor

@riedgar-ms riedgar-ms commented May 18, 2023 •
edited
Loading

Motivation and Context

This introduces functions related to groundedness checking, based on learnings from the Aether Central team. The skills are showcased in both an Python notebook and a .NET sample.

Description

Contribution Checklist

@riedgar-ms riedgar-ms mentioned this pull request May 22, 2023
Closed
@riedgar-ms riedgar-ms mentioned this pull request May 22, 2023
Closed
@github-actions github-actions bot removed the python Pull requests for the Python Semantic Kernel label Jun 14, 2023
@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: feedback to address Waiting for PR owner to address comments/questions PR: ready to merge PR has been approved by all reviewers, and is ready to merge. labels Jun 14, 2023
@lemillermicrosoft lemillermicrosoft added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Jun 14, 2023
@lemillermicrosoft lemillermicrosoft added PR: feedback to address Waiting for PR owner to address comments/questions and removed PR: ready to merge PR has been approved by all reviewers, and is ready to merge. labels Jun 15, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) June 15, 2023 18:43
alexchaomander
alexchaomander approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for adding this important skill to SK!

@lemillermicrosoft lemillermicrosoft merged commit 4b68d6a into microsoft:main Jun 15, 2023
15 checks passed
@lemillermicrosoft lemillermicrosoft added this to the Sprint 33 milestone Jun 20, 2023
@nacharya1 nacharya1 changed the title Add Grounding Skill to Samples Python: Add Grounding Skill to Samples Jul 3, 2023
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@riedgar-ms @lemillermicrosoft
Add Grounding Skill to Samples (microsoft#1064)
f74abfa 
### Motivation and Context
This introduces functions related to groundedness checking, based on
learnings from the Aether Central team. The skills are showcased in both
an Python notebook and a .NET sample.

---------

Co-authored-by: Lee Miller <lemiller@microsoft.com>
Co-authored-by: Lee Miller <lemillermicrosoft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexchaomander alexchaomander alexchaomander approved these changes

@lemillermicrosoft lemillermicrosoft lemillermicrosoft left review comments

Assignees

@lemillermicrosoft lemillermicrosoft

Labels
.NET Issue or Pull requests regarding .NET code PR: feedback to address Waiting for PR owner to address comments/questions PR: ready for review All feedback addressed, ready for reviews
Projects
Semantic Kernel
Archived in project
Python Semantic Kernel
Status: Sprint: Done
Milestone
Sprint 33
Development

Successfully merging this pull request may close these issues.
3 participants
@riedgar-ms @lemillermicrosoft @alexchaomander