-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug preventing Qdrant points with numeric id from being consumed #1075
Fix bug preventing Qdrant points with numeric id from being consumed #1075
Conversation
…tion (Qdrant allows either string or int for this Id)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an effective and efficient solution for this!
…icrosoft#1075) ### Motivation and Context Qdrant supports both string and int for the id of a ScoredPoint. This minor change allows the serialiser to handle both of these scenarios while retaining string as the type for SK. Thank you to @AwesomeYuer for the heads up in microsoft#794 ### Description Added a single attribute decorating the attribute that massages ints to string and leaves string as-is.
glad to hear that |
when call the function "kernel.Memory.SaveInformationAsync", the ID is assigned to a GUID, Starting in .NET 6, if you apply JsonNumberHandlingAttribute to a property that's a collection of non-number values and attempt to serialize or deserialize the property, an InvalidOperationException is thrown. |
### Motivation and Context This PR fixes a regression introduced in #1075 and includes unit tests to correctly validate that both string and integer property ids are supported. ### Description The changes are based on the code suggested by AwesomeYuer over in #794 - the JsonNumberHandling attribute behaved in an unexpected way and was removed.
…oft#1313) ### Motivation and Context This PR fixes a regression introduced in microsoft#1075 and includes unit tests to correctly validate that both string and integer property ids are supported. ### Description The changes are based on the code suggested by AwesomeYuer over in microsoft#794 - the JsonNumberHandling attribute behaved in an unexpected way and was removed.
…oft#1313) ### Motivation and Context This PR fixes a regression introduced in microsoft#1075 and includes unit tests to correctly validate that both string and integer property ids are supported. ### Description The changes are based on the code suggested by AwesomeYuer over in microsoft#794 - the JsonNumberHandling attribute behaved in an unexpected way and was removed.
Motivation and Context
Qdrant supports both string and int for the id of a ScoredPoint. This minor change allows the serialiser to handle both of these scenarios while retaining string as the type for SK.
Thank you to @AwesomeYuer for the heads up in #794
Description
Added a single attribute decorating the attribute that massages ints to string and leaves string as-is.
Contribution Checklist
dotnet format