Fix incorrect attribute causing the Qdrant connector to break #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h string and integer. Add unit tests covering both cases
github-actions
bot
added
.NET
craigomatic
added
PR: ready for review
dmytrostruk
reviewed
Jun 2, 2023
dotnet/src/Connectors/Connectors.Memory.Qdrant/Http/ApiSchema/SearchVectorsResponse.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
kernel
dmytrostruk
approved these changes
Jun 2, 2023
dmytrostruk
added
the
PR: ready to merge
adrianwyatt
approved these changes
Jun 2, 2023
This was referenced Jun 2, 2023
Closed
salmon131
pushed a commit
to salmon131/semantic-kernel
that referenced
this pull request
Jun 3, 2023
…oft#1313) ### Motivation and Context This PR fixes a regression introduced in microsoft#1075 and includes unit tests to correctly validate that both string and integer property ids are supported. ### Description The changes are based on the code suggested by AwesomeYuer over in microsoft#794 - the JsonNumberHandling attribute behaved in an unexpected way and was removed.
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
…oft#1313) ### Motivation and Context This PR fixes a regression introduced in microsoft#1075 and includes unit tests to correctly validate that both string and integer property ids are supported. ### Description The changes are based on the code suggested by AwesomeYuer over in microsoft#794 - the JsonNumberHandling attribute behaved in an unexpected way and was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes a regression introduced in #1075 and includes unit tests to correctly validate that both string and integer property ids are supported.
Description
The changes are based on the code suggested by AwesomeYuer over in #794 - the JsonNumberHandling attribute behaved in an unexpected way and was removed.
Contribution Checklist
dotnet format