Remove System.Linq.Async dependency from SK #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
stephentoub
force-pushed
the
removeasynclinq
branch
from
1df0d69
to
6c4abbc
Compare
shawncal
approved these changes
Jun 2, 2023
We're using very little of the library and can easily achieve the same things without it. From the core libraries like abstractions, we shouldn't force all consumers to take the additional 1MB dependency From examples, we shouldn't force anyone copying/pasting to take the additional dependency Also removed unnecessary InternalsVisibleTo that were also interfering with shared source in multiple assemblies.
salmon131
pushed a commit
to salmon131/semantic-kernel
that referenced
this pull request
Jun 3, 2023
We're using very little of the library and can easily achieve the same things without it. From the core libraries like abstractions, we shouldn't force all consumers to take the additional 1MB dependency. And from examples, we shouldn't force anyone copying/pasting to take the additional dependency Also removed unnecessary InternalsVisibleTo that were also interfering with shared source in multiple assemblies.
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
We're using very little of the library and can easily achieve the same things without it. From the core libraries like abstractions, we shouldn't force all consumers to take the additional 1MB dependency. And from examples, we shouldn't force anyone copying/pasting to take the additional dependency Also removed unnecessary InternalsVisibleTo that were also interfering with shared source in multiple assemblies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We're using very little of the library and can easily achieve the same things without it. From the core libraries like abstractions, we shouldn't force all consumers to take the additional 1MB dependency. And from examples, we shouldn't force anyone copying/pasting to take the additional dependency
Also removed unnecessary InternalsVisibleTo that were also interfering with shared source in multiple assemblies.
Contribution Checklist
dotnet format