.Net: Simplify chatgpt plugin import method names #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigomatic
added
the
PR: in progress
shawncal
added
.NET
shawncal
changed the title
…ate calling code. Mark prior extensions as obsolete
…ic/semantic-kernel into chatgpt-plugin-cleanup
…ing to SK's underlying validator
…or stream and file on disk
craigomatic
added
PR: ready for review
dotnet/src/Skills/Skills.OpenAPI/Extensions/KernelAIPluginExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Skills/Skills.OpenAPI/Extensions/KernelAIPluginExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Skills/Skills.OpenAPI/Extensions/KernelAIPluginExtensions.cs
Outdated
Show resolved
Hide resolved
craigomatic
added
the
PR: ready to merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shawncal
approved these changes
Aug 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
shawncal
reviewed
Aug 4, 2023
shawncal
approved these changes
Aug 4, 2023
…ic/semantic-kernel into chatgpt-plugin-cleanup
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Description Several extension methods were previously supplied that allow loading plugins from remote URI, local files, streams and from a given directory. They also were specific to OpenAPI and ChatGPT. This PR marks those extensions as Obsolete (KernelChatGptPluginExtensions.cs and KernelOpenApiExtensions.cs) and supplies a single `ImportAIPluginAsync` in a new extension file which expects a URI or a Stream to import from. For resources of any other form, the caller is expected to carry the burden of getting them to a stream or a URI. A single integration test has been added that imports the Klarna AI Plugin using both it's ChatGPT representation (https://www.klarna.com/.well-known/ai-plugin.json) and the OpenAPI representation (https://www.klarna.com/us/shopping/public/openai/v0/api-docs/) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Craig Presti <craig.presti@microsoft.com> Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several extension methods were previously supplied that allow loading plugins from remote URI, local files, streams and from a given directory. They also were specific to OpenAPI and ChatGPT.
This PR marks those extensions as Obsolete (KernelChatGptPluginExtensions.cs and KernelOpenApiExtensions.cs) and supplies a single
ImportAIPluginAsyncin a new extension file which expects a URI or a Stream to import from. For resources of any other form, the caller is expected to carry the burden of getting them to a stream or a URI.A single integration test has been added that imports the Klarna AI Plugin using both it's ChatGPT representation (https://www.klarna.com/.well-known/ai-plugin.json) and the OpenAPI representation (https://www.klarna.com/us/shopping/public/openai/v0/api-docs/)
Contribution Checklist