Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Removing obsolete code for connectors and their registration. #2013

Merged
merged 5 commits into from
Jul 17, 2023

Conversation

SergeyMenshykh
Copy link
Member

Description

All code marked by the Obsolete attribute related to for connectors and their registration is removed.

Contribution Checklist

@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner July 17, 2023 11:33
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core memory connector labels Jul 17, 2023
@shawncal shawncal changed the title Removing obsolete code for connectors and their registration. .Net: Removing obsolete code for connectors and their registration. Jul 17, 2023
@SergeyMenshykh SergeyMenshykh added the PR: ready for review All feedback addressed, ready for reviews label Jul 17, 2023
@SergeyMenshykh
Copy link
Member Author

@rogerbarretto, @stephentoub I can see that you marked a few classes/methods as obsolete some time ago. I can remove that code in this PR unless you want to do it yourselves later.

@stephentoub
Copy link
Member

I can see that you marked a few classes/methods as obsolete some time ago. I can remove that code in this PR unless you want to do it yourselves later.

From my perspective, please do. Thanks.

@shawncal shawncal added this pull request to the merge queue Jul 17, 2023
Merged via the queue into microsoft:main with commit dfe3912 Jul 17, 2023
11 checks passed
@lemillermicrosoft lemillermicrosoft added the PR: breaking change Pull requests that introduce breaking changes label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory connector .NET Issue or Pull requests regarding .NET code PR: breaking change Pull requests that introduce breaking changes PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants