Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Remove example 37 as it is a duplicate of example 45 #4148

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Dec 11, 2023

Motivation and Context

Example 37 is a duplicate of example 45.
It also contains multiple issues that were addressed in example 45.

Description

Remove example 37

Contribution Checklist

@glahaye glahaye requested a review from a team as a code owner December 11, 2023 00:48
@shawncal shawncal added the .NET Issue or Pull requests regarding .NET code label Dec 11, 2023
@glahaye glahaye self-assigned this Dec 11, 2023
@github-actions github-actions bot changed the title Remove example 37 as it is a duplicate of example 45 .Net: Remove example 37 as it is a duplicate of example 45 Dec 11, 2023
@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Dec 11, 2023
Merged via the queue into microsoft:main with commit 1169245 Dec 11, 2023
18 checks passed
Kevdome3000 pushed a commit to Kevdome3000/semantic-kernel that referenced this pull request Dec 11, 2023
…#4148)

### Motivation and Context
Example 37 is a duplicate of example 45.
It also contains multiple issues that were addressed in example 45.

### Description
Remove example 37

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

(cherry picked from commit 1169245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.Net: Example37_MultiStreamingCompletion - Needs clarification + calibration
4 participants