Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Integration Tests for Function Calling Stepwise Planner #4189

Merged
merged 9 commits into from
Dec 12, 2023
Merged

.Net: Integration Tests for Function Calling Stepwise Planner #4189

merged 9 commits into from
Dec 12, 2023

Conversation

gitri-ms
Copy link
Contributor

@gitri-ms gitri-ms commented Dec 12, 2023 •
edited

Motivation and Context / Description

  • The integration tests for Function Calling Stepwise Planner were removed when we refactored/removed Planners.Core. This adds them back and improves them with more test cases and results validation.
  • Also includes a minor fix in sample code (ChatHistory.AsJson() no longer exists)

Contribution Checklist

@gitri-ms gitri-ms self-assigned this Dec 12, 2023
@gitri-ms gitri-ms requested a review from a team as a code owner December 12, 2023 02:16
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Dec 12, 2023
@github-actions github-actions bot changed the title Integration Tests for Function Calling Stepwise Planner .Net: Integration Tests for Function Calling Stepwise Planner Dec 12, 2023
@markwallace-microsoft markwallace-microsoft added the v1.0.1 Required for the Semantic Kernel v1.0.1 release label Dec 12, 2023
@gitri-ms gitri-ms added this pull request to the merge queue Dec 12, 2023
Merged via the queue into microsoft:main with commit 38ac687 Dec 12, 2023
18 checks passed
@gitri-ms gitri-ms deleted the stepwise-planner-tests branch December 12, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytrostruk dmytrostruk dmytrostruk approved these changes

@alliscode alliscode alliscode approved these changes

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

Assignees

@gitri-ms gitri-ms

Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code v1.0.1 Required for the Semantic Kernel v1.0.1 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gitri-ms @dmytrostruk @alliscode @SergeyMenshykh @markwallace-microsoft @shawncal