Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Removes the _async suffix where is not needed #4735

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Python: Removes the _async suffix where is not needed #4735

merged 8 commits into from
Jan 26, 2024

Conversation

juliomenendez
Copy link
Contributor

Motivation and Context

Delete all *_async where *_sync doesn't exist to make the library more Pythonic.

Fixes #4629

Contribution Checklist

@juliomenendez juliomenendez requested a review from a team as a code owner January 24, 2024 20:44
@shawncal shawncal added python Pull requests for the Python Semantic Kernel memory labels Jan 24, 2024
eavanvalkenburg
eavanvalkenburg requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick look, overall looking pretty good, some small notes. And we should also add a note to DEV_SETUP.md that a developer should assume everything is async!

python/samples/kernel-syntax-examples/bing_search_plugin.py Show resolved Hide resolved
python/samples/kernel-syntax-examples/google_search_plugin.py Show resolved Hide resolved
moonbox3
moonbox3 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eavanvalkenburg
eavanvalkenburg approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moonbox3 moonbox3 added this pull request to the merge queue Jan 26, 2024
@moonbox3 moonbox3 removed this pull request from the merge queue due to a manual request Jan 26, 2024
@moonbox3
Copy link
Contributor

There are some integration tests that still call kernel.run_async(), for example test_azure_oai_chat_service: the tests should just be kernel.run().

summary = await retry(lambda: kernel.run(tldr_function, input_str=text_to_summarize))

@moonbox3 moonbox3 added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@moonbox3 moonbox3 added this pull request to the merge queue Jan 26, 2024
Merged via the queue into microsoft:main with commit d97f953 Jan 26, 2024
26 checks passed
@juliomenendez juliomenendez deleted the juliome/issue-4629-remove-async-suffix branch January 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees
No one assigned
Labels
documentation memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Delete all *_async where *_sync doesn't exist
4 participants
@juliomenendez @moonbox3 @eavanvalkenburg @shawncal