Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Delete all *_async where *_sync doesn't exist #4629

Closed
matthewbolanos opened this issue Jan 16, 2024 · 0 comments · Fixed by #4735
Closed

Python: Delete all *_async where *_sync doesn't exist #4629

matthewbolanos opened this issue Jan 16, 2024 · 0 comments · Fixed by #4735
Assignees
@juliomenendez
Labels
kernel Issues or pull requests impacting the core kernel needs help These are issues that are good candidates for the community to work on python Pull requests for the Python Semantic Kernel

Comments

@matthewbolanos
Copy link
Member

matthewbolanos commented Jan 16, 2024 •
edited
Loading

This issue is to ensure the Python SDK is idiomatic with Python. Where there aren't different async/sync methods, the _async suffix should be removed.
@shawncal shawncal added python Pull requests for the Python Semantic Kernel triage labels Jan 16, 2024
@matthewbolanos matthewbolanos added kernel Issues or pull requests impacting the core kernel needs help These are issues that are good candidates for the community to work on and removed triage labels Jan 16, 2024
@juliomenendez juliomenendez mentioned this issue Jan 24, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2024
@juliomenendez @moonbox3
Python: Removes the _async suffix where is not needed (#4735)
d97f953 
### Motivation and Context
Delete all *_async where *_sync doesn't exist to make the library more
Pythonic.

Fixes #4629 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Bryan-Roe pushed a commit to Bryan-Roe/semantic-kernel that referenced this issue Oct 6, 2024
@juliomenendez @moonbox3
Python: Removes the _async suffix where is not needed (microsoft#4735)
cb0f529 
### Motivation and Context
Delete all *_async where *_sync doesn't exist to make the library more
Pythonic.

Fixes microsoft#4629 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliomenendez juliomenendez

Labels
kernel Issues or pull requests impacting the core kernel needs help These are issues that are good candidates for the community to work on python Pull requests for the Python Semantic Kernel
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: Removes the _async suffix where is not needed juliomenendez/semantic-kernel
3 participants
@juliomenendez @matthewbolanos @shawncal