Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: ADR for audio abstraction and implementation renaming #5117

Merged
merged 10 commits into from
Mar 14, 2024

Conversation

dmytrostruk
Copy link
Member

Motivation and Context

Added ADR for audio abstraction and implementation renaming for further discussion and agreement.

Contribution Checklist

@Krzysztof318
Copy link
Contributor

Krzysztof318 commented Feb 22, 2024

I would add content about live/continuous streaming audio-to-text and text-to-audio, how it should be abstracted, to this ADR.
This PR #5094 proposed a new class AudioStreamContent.
Abstraction should support full real time streaming, when we sending an audio stream and service returns IAsyncEnumerable<StreamingTextContent>

@dmytrostruk
Copy link
Member Author

I would add content about live/continuous streaming audio-to-text and text-to-audio, how it should be abstracted, to this ADR. This PR #5094 proposed a new class AudioStreamContent. Abstraction should support full real time streaming, when we sending an audio stream and service returns IAsyncEnumerable<StreamingTextContent>

I believe it's out-of-scope of this ADR, because currently we want to align our vision in terms of naming. Regarding streaming, my initial thoughts are to implement it in similar way how it's done in IChatCompletionService at the moment. One interface method for non-streaming scenario and one for streaming scenario. Method signature should be similar to other abstractions we have at the moment. But it's just general ideas, in order to understand better how streaming abstraction should look like, we have to take a couple of AI providers which support that functionality, compare their API shape and try to find common denominator. This work may potentially take separate ADR if needed and I'm not sure what priority it has at the moment.

@dmytrostruk dmytrostruk added this pull request to the merge queue Mar 14, 2024
Merged via the queue into microsoft:main with commit 74d61ed Mar 14, 2024
12 checks passed
@dmytrostruk dmytrostruk deleted the audio-abstraction-adr branch March 14, 2024 16:15
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…t#5117)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Added ADR for audio abstraction and implementation renaming for further
discussion and agreement.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants