Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Added metadata specifying connection stems from MSK code #5269

Merged
merged 5 commits into from
May 7, 2024

Conversation

BorisDog
Copy link
Contributor

@BorisDog BorisDog commented Mar 1, 2024

Motivation and Context

Description

MongoDB drivers are used in various flavors and languages. Making sure we exercise our due diligence in identifying the "origin" of the library calls makes it best to understand how our Atlas servers get accessed.
Similar to Python PR.

Contribution Checklist

@BorisDog BorisDog requested a review from a team as a code owner March 1, 2024 23:07
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Mar 1, 2024
@github-actions github-actions bot changed the title .NET: Added metadata specifying connection stems from MSK code .Net: Added metadata specifying connection stems from MSK code Mar 1, 2024
@dmytrostruk dmytrostruk enabled auto-merge May 7, 2024 14:05
@dmytrostruk dmytrostruk added this pull request to the merge queue May 7, 2024
Merged via the queue into microsoft:main with commit 45f3d56 May 7, 2024
15 checks passed
@prakul
Copy link

prakul commented May 7, 2024

Thanks for reviewing the PR @dmytrostruk and @markwallace-microsoft!

@BorisDog BorisDog deleted the mongodb_driverinfo_update branch May 7, 2024 16:22
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…soft#5269)

### Motivation and Context
### Description

MongoDB drivers are used in various flavors and languages. Making sure
we exercise our due diligence in identifying the "origin" of the library
calls makes it best to understand how our Atlas servers get accessed.
Similar to [Python
PR](microsoft#3419).

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants