Python: Fix - Action Planner breaking when parameters are not explicitly given in the ask #5590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution to the issue: microsoft#5583 Just adding a check before trying to assign values to parameters does the job.
Update action_planner.py
markwallace-microsoft
added
the
python
moonbox3
approved these changes
Mar 25, 2024
|
Hi @ArfiArfath21, can you please run black formatting? It's currently failing on a file. Thank you. |
Python 3.8 Test Coverage Report •
Python 3.8 Unit Test Overview
|
||||||||||||||||||||||||||||||
|
Hi @moonbox3 Thanks |
eavanvalkenburg
approved these changes
Mar 25, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…tly given in the ask (microsoft#5590) Solution to the issue: Python: Action Planner breaking when parameters are not explicitly given in the ask microsoft#5583 ### Motivation and Context The action planner breaks when the user does not provide specific parameters in the ask/goal. Users might have generic questions like "what is the date today?". Fix for the issue microsoft#5583 ### Description Just adding an IF condition before iterating through the generated_plan variable to check if parameters are present or not does the job. Added unit test for a case like the example give above. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: arfsyed <arfath.syed@unilever.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to the issue: Python: Action Planner breaking when parameters are not explicitly given in the ask
#5583
Motivation and Context
The action planner breaks when the user does not provide specific parameters in the ask/goal. Users might have generic questions like "what is the date today?". Fix for the issue #5583
Description
Just adding an IF condition before iterating through the generated_plan variable to check if parameters are present or not does the job. Added unit test for a case like the example give above.
Contribution Checklist