-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net - Add support for Name property to ChatMessageContent #5666
Conversation
@markwallace-microsoft These signature changes won't break any consumer's build. How do we update our baseline? |
|
Thanks, I must've been missing the |
FYI - Engaged with Matthew and re-evaluating |
…microsoft/semantic-kernel into fix_chatmessagecontent_identity
FYI - Name not returned in response: REQUEST
RESPONSE
|
dotnet/src/SemanticKernel.Abstractions/Contents/StreamingChatMessageContent.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/ChatMessageContent.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/StreamingChatMessageContent.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/StreamingChatMessageContent.cs
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatHistory.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Contents/ChatMessageContent.cs
Outdated
Show resolved
Hide resolved
…microsoft/semantic-kernel into fix_chatmessagecontent_identity
…#5666) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Tracking identity is critical for multi-agent conversations. It is also supported as part of the core chat-completion api: https://platform.openai.com/docs/api-reference/chat/create ``` { "messages": [ { "content": "Write one paragraph in response to the user that rhymes", "name": "Echo", "role": "system" }, { "content": "Why is AI awesome", "name": "Ralph", "role": "user" } ], "temperature": 1, "top_p": 0.5, "n": 3, "presence_penalty": 0, "frequency_penalty": 0, "model": "gpt-4" } ``` ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Add support for `ChatMessageContent.Name` property with optional, non-breaking patterns. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: markwallace-microsoft <127216156+markwallace-microsoft@users.noreply.github.com>
Motivation and Context
Tracking identity is critical for multi-agent conversations. It is also supported as part of the core chat-completion api: https://platform.openai.com/docs/api-reference/chat/create
Description
Add support for
ChatMessageContent.Name
property with optional, non-breaking patterns.Contribution Checklist