.Net Hugging Face TGI Chat Completion Message API Support #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto features/hugging-face-tgi-chat-completion
…nto features/hugging-face-tgi-chat-completion
Krzysztof318
suggested changes
Apr 6, 2024
...t/src/Connectors/Connectors.HuggingFace.UnitTests/Services/HuggingFaceChatCompletionTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceOpenAIClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceOpenAIClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceOpenAIClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Models/TextGenerationMetadata.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Models/TextGenerationStreamMetadata.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceOpenAIClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceClient.cs
Outdated
Show resolved
Hide resolved
|
Consider creating also generic SseData class |
dotnet/src/Connectors/Connectors.HuggingFace/Core/Models/TextEmbeddingResponse.cs
Outdated
Show resolved
Hide resolved
|
What's the plan for automatic function calling? Is that going to be in this PR or a follow-up? |
@RogerBarreto for reference, here is guidance from HF for tool calling support as part of the Messages API https://huggingface.co/docs/text-generation-inference/conceptual/guidance#tools-and-functions- |
@luisquintanilla, this PR already adds function calling support... but manual. It's the automated part I was asking about, i.e. where SK itself reads and responds to tool invocation requests rather than passing those back to the caller. |
|
@stephentoub @luisquintanilla The tool calling behavior will be added as soon we have the abstractions in place. Currently the only piece added to this PR is the |
…nto features/hugging-face-tgi-chat-completion
dmytrostruk
reviewed
Apr 13, 2024
dotnet/src/Connectors/Connectors.HuggingFace.UnitTests/Connectors.HuggingFace.UnitTests.csproj
Outdated
Show resolved
Hide resolved
...t/src/Connectors/Connectors.HuggingFace.UnitTests/Services/HuggingFaceChatCompletionTests.cs
Outdated
Show resolved
Hide resolved
...nectors/Connectors.HuggingFace.UnitTests/Services/HuggingFaceStreamingChatCompletionTests.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/Models/TextGenerationRequest.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/HuggingFaceKernelBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/HuggingFaceServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Services/HuggingFaceChatCompletionService.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Services/HuggingFaceChatCompletionService.cs
Outdated
Show resolved
Hide resolved
RogerBarreto
changed the title
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceMessageApiClient.cs
Show resolved
Hide resolved
markwallace-microsoft
approved these changes
Apr 15, 2024
…nto features/hugging-face-tgi-chat-completion
dmytrostruk
approved these changes
Apr 16, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…5785) ### Motivation and Context Closes microsoft#5403 1. Adding support to Chat Completion for TGI (Text Generation Inference) Deployment. 3. Adding Missing UnitTests for Streaming and Non Streaming scenarios (Text/Chat Completion) 4. Update Metadata + Usage Details for hugging face clients. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #5403
Contribution Checklist