.Net: Upgrade projects from net6.0 to net8.0 and adjust LangVersion to 12 #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stephentoub
commented
Apr 9, 2024
stephentoub
commented
- Test projects targeting net6.0 are updated to net8.0
- LangVersion is consolidated to be 12 and set only in the top-level Directory.Build.props
- RollForward was used to enable test projects targeting net6.0 to execute in CI when there was only a net8.0 runtime present. These can all be deleted.
- Microsoft.Net.Compilers.Toolset was used in a bunch of places to allow for LangVersion 12 when on older toolsets. Now that the .NET 8 SDK is used, this can all be deleted.
- Microsoft.CodeAnalysis.NetAnalyzers was pinned to the 8.0 version. That can now be deleted.
- Allowing the analyzers to use a newer build by default flagged a bunch of CA2007 violations to be addressed. These have all been fixed.
- Test projects targeting net6.0 are updated to net8.0 - LangVersion is consolidated to be 12 and set only in the top-level Directory.Build.props - RollForward was used to enable test projects targeting net6.0 to execute in CI when there was only a net8.0 runtime present. These can all be deleted. - Microsoft.Net.Compilers.Toolset was used in a bunch of places to allow for LangVersion 12 when on older toolsets. Now that the .NET 8 SDK is used, this can all be deleted. - Microsoft.CodeAnalysis.NetAnalyzers was pinned to the 8.0 version. That can now be deleted. - Allowing the analyzers to use a newer build by default flagged a bunch of CA2007 violations to be addressed. These have all been fixed.
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Apr 9, 2024
SergeyMenshykh
approved these changes
Apr 9, 2024
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…o 12 (microsoft#5819) - Test projects targeting net6.0 are updated to net8.0 - LangVersion is consolidated to be 12 and set only in the top-level Directory.Build.props - RollForward was used to enable test projects targeting net6.0 to execute in CI when there was only a net8.0 runtime present. These can all be deleted. - Microsoft.Net.Compilers.Toolset was used in a bunch of places to allow for LangVersion 12 when on older toolsets. Now that the .NET 8 SDK is used, this can all be deleted. - Microsoft.CodeAnalysis.NetAnalyzers was pinned to the 8.0 version. That can now be deleted. - Allowing the analyzers to use a newer build by default flagged a bunch of CA2007 violations to be addressed. These have all been fixed.
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
…o 12 (microsoft#5819) - Test projects targeting net6.0 are updated to net8.0 - LangVersion is consolidated to be 12 and set only in the top-level Directory.Build.props - RollForward was used to enable test projects targeting net6.0 to execute in CI when there was only a net8.0 runtime present. These can all be deleted. - Microsoft.Net.Compilers.Toolset was used in a bunch of places to allow for LangVersion 12 when on older toolsets. Now that the .NET 8 SDK is used, this can all be deleted. - Microsoft.CodeAnalysis.NetAnalyzers was pinned to the 8.0 version. That can now be deleted. - Allowing the analyzers to use a newer build by default flagged a bunch of CA2007 violations to be addressed. These have all been fixed.
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…o 12 (microsoft#5819) - Test projects targeting net6.0 are updated to net8.0 - LangVersion is consolidated to be 12 and set only in the top-level Directory.Build.props - RollForward was used to enable test projects targeting net6.0 to execute in CI when there was only a net8.0 runtime present. These can all be deleted. - Microsoft.Net.Compilers.Toolset was used in a bunch of places to allow for LangVersion 12 when on older toolsets. Now that the .NET 8 SDK is used, this can all be deleted. - Microsoft.CodeAnalysis.NetAnalyzers was pinned to the 8.0 version. That can now be deleted. - Allowing the analyzers to use a newer build by default flagged a bunch of CA2007 violations to be addressed. These have all been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.