Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net BugFix Issue 6058 Changing Dictionary in Enumeration #6067

Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
3dd55f4
Preparing 1.1 release
RogerBarreto Jan 16, 2024
8de6748
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Jan 16, 2024
5bbd7fc
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Jan 18, 2024
f8a5bcb
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Jan 23, 2024
80ea9b0
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Jan 26, 2024
e53fbf7
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Feb 12, 2024
4cfba8f
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Feb 15, 2024
8075acf
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Feb 15, 2024
d9353ac
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Feb 20, 2024
06fb5e1
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 4, 2024
93e8925
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 4, 2024
4c78c09
Merge branch 'main' of github.com:microsoft/semantic-kernel
RogerBarreto Mar 6, 2024
e3c891d
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 13, 2024
61790bd
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 13, 2024
e4e543a
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 14, 2024
5722494
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 14, 2024
cbd5fa3
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 15, 2024
4f7d1bd
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 20, 2024
b8e01f9
Merge branch 'microsoft:main' into main
RogerBarreto Mar 20, 2024
87f70c1
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 25, 2024
97f432f
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 27, 2024
eeb54e2
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Mar 28, 2024
b98098f
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 3, 2024
aa2f3f5
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 5, 2024
72acf1a
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 8, 2024
186e366
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 15, 2024
9fa2e5e
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 16, 2024
17ff945
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 18, 2024
80b5d0e
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 23, 2024
4b93b43
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 24, 2024
fd23a3f
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 24, 2024
21988ce
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 26, 2024
8b26dc1
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 29, 2024
d53db3d
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 29, 2024
c338909
Merge branch 'main' of https://github.com/microsoft/semantic-kernel
RogerBarreto Apr 30, 2024
b8ad85d
Fix changing dictonary while enumerating
RogerBarreto Apr 30, 2024
76bbf1c
Update dotnet/src/Connectors/Connectors.OpenAI/AzureSdk/ClientCore.cs
RogerBarreto May 1, 2024
f170e66
Merge branch 'main' into issues/6058-bug-changing-dic-in-enumeration
RogerBarreto May 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1221,9 +1221,11 @@ private OpenAIChatMessageContent GetChatMessage(ChatChoice chatChoice, ChatCompl
arguments = JsonSerializer.Deserialize<KernelArguments>(functionToolCall.Arguments);
if (arguments is not null)
{
foreach (var argument in arguments)
// Iterate over copy of the names to avoid mutating the dictionary while enumerating it
var names = arguments.Names.ToArray();
RogerBarreto marked this conversation as resolved.
Show resolved Hide resolved
foreach (var name in names)
{
arguments[argument.Key] = argument.Value?.ToString();
arguments[name] = arguments[name]?.ToString();
}
}
}
Expand Down
Loading