-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Add model diagnostics to non-streaming APIs #6150
Merged
TaoChenOSU
merged 16 commits into
microsoft:main
from
TaoChenOSU:taochen/add-model-diagnostics-to-non-streaming-apis
May 10, 2024
Merged
.Net: Add model diagnostics to non-streaming APIs #6150
TaoChenOSU
merged 16 commits into
microsoft:main
from
TaoChenOSU:taochen/add-model-diagnostics-to-non-streaming-apis
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
commented
May 7, 2024
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
TaoChenOSU
commented
May 7, 2024
TaoChenOSU
commented
May 7, 2024
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceMessageApiClient.cs
Outdated
Show resolved
Hide resolved
TaoChenOSU
commented
May 7, 2024
dotnet/src/Connectors/Connectors.Google/Core/Gemini/Clients/GeminiChatCompletionClient.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 8, 2024
dotnet/src/Connectors/Connectors.Google/Core/Gemini/Clients/GeminiChatCompletionClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceMessageApiClient.cs
Outdated
Show resolved
Hide resolved
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 8, 2024
dotnet/src/Connectors/Connectors.Google/Core/Gemini/Clients/GeminiChatCompletionClient.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 8, 2024
dotnet/src/Connectors/Connectors.HuggingFace/Core/HuggingFaceClient.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 8, 2024
dotnet/src/InternalUtilities/src/Diagnostics/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 8, 2024
dotnet/src/InternalUtilities/src/Diagnostics/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
May 8, 2024
lmolkova
reviewed
May 8, 2024
lmolkova
reviewed
May 8, 2024
lmolkova
reviewed
May 8, 2024
lmolkova
reviewed
May 8, 2024
stephentoub
reviewed
May 9, 2024
stephentoub
reviewed
May 9, 2024
stephentoub
reviewed
May 9, 2024
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 9, 2024
dotnet/src/InternalUtilities/src/Diagnostics/ModelDiagnostics.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
May 9, 2024
alliscode
approved these changes
May 10, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Previously (#6150) we added support for OTel (LLM semantic conventions) to non-streaming APIs in the AI connectors. This PR adds that to streaming APIs. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Add OTel (LLM semantic conventions) to streaming APIs. 2. Update the telemetry sample to use streaming APIs along with non-streaming ones.. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> According to the [ADR](https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0044-OTel-semantic-convention.md), it's essential that SK provides the best developer experience while complying with the industry standards for observability in generative-AI-based applications. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> This PR adds instrumentation to the chat completion and text completion endpoints in all AI connectors. Streaming APIs will be worked on next. The telemetry sample and the documentation will be updated in a separate PR. > Note that this is an ongoing effort, i.e. metrics and more events will be added as the conventions evolve. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Previously (microsoft#6150) we added support for OTel (LLM semantic conventions) to non-streaming APIs in the AI connectors. This PR adds that to streaming APIs. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Add OTel (LLM semantic conventions) to streaming APIs. 2. Update the telemetry sample to use streaming APIs along with non-streaming ones.. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kernel.core
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
According to the ADR, it's essential that SK provides the best developer experience while complying with the industry standards for observability in generative-AI-based applications.
Description
This PR adds instrumentation to the chat completion and text completion endpoints in all AI connectors.
Streaming APIs will be worked on next.
The telemetry sample and the documentation will be updated in a separate PR.
Contribution Checklist