Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fixed warning in release pipeline about Docker base image in examples #6340

Merged
merged 1 commit into from
May 20, 2024

Conversation

dmytrostruk
Copy link
Member

Motivation and Context

There is a warning about using python:3.12 base image in release pipeline for one of our demo applications. I moved the content of Dockerfile to README, so it can be used as an example.

Contribution Checklist

@dmytrostruk dmytrostruk self-assigned this May 20, 2024
@dmytrostruk dmytrostruk requested a review from a team as a code owner May 20, 2024 18:54
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code documentation labels May 20, 2024
@dmytrostruk dmytrostruk added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@dmytrostruk dmytrostruk added this pull request to the merge queue May 20, 2024
Merged via the queue into microsoft:main with commit 06a3ce0 May 20, 2024
17 checks passed
@dmytrostruk dmytrostruk deleted the fix-pipeline-warning branch May 20, 2024 20:36
LudoCorporateShark pushed a commit to LudoCorporateShark/semantic-kernel that referenced this pull request Aug 25, 2024
…amples (microsoft#6340)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

There is a warning about using `python:3.12` base image in release
pipeline for one of our demo applications. I moved the content of
Dockerfile to README, so it can be used as an example.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants