Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: added readme #6390

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Conversation

yorek
Copy link
Member

@yorek yorek commented May 24, 2024

Added readme and sample for Microsoft.SemanticKernel.Connectors.SqlServer

@yorek yorek requested a review from a team as a code owner May 24, 2024 18:36
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation memory labels May 24, 2024
@github-actions github-actions bot changed the title added readme .Net: added readme May 24, 2024
@yorek
Copy link
Member Author

yorek commented May 24, 2024

Adding also @cincuranet as he worked on the connector and provided the sample

Copy link
Member

@dmytrostruk dmytrostruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding documentation!

yorek and others added 4 commits May 25, 2024 12:17
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
@cincuranet
Copy link
Contributor

LGTM

@yorek
Copy link
Member Author

yorek commented Jun 5, 2024

Cam this PR be merged (so that I can write a blog post on this?) Thanks!

@markwallace-microsoft markwallace-microsoft added this pull request to the merge queue Jun 5, 2024
Merged via the queue into microsoft:main with commit 4fb6463 Jun 5, 2024
15 checks passed
@yorek
Copy link
Member Author

yorek commented Jun 5, 2024

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants