Planning example improvements #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
lemillermicrosoft
force-pushed
the
425_plan_buckets_functionview
branch
from
90db746
to
12a6c71
Compare
lemillermicrosoft
added
the
PR: ready for review
shawncal
reviewed
Apr 26, 2023
lemillermicrosoft
force-pushed
the
425_plan_buckets_functionview
branch
from
12a6c71
to
4590c16
Compare
This commit removes the BucketOutputs function from the PlannerConfig and the SemanticFunctionConstants files, as it is no longer needed or compatible with the current plan creation process. It also updates the documentation to reflect the changes in the available functions and the function input and output types. Additionally, it removes a redundant TODO comment from the SequentialPlanParser file.
This commit applies some minor refactoring and formatting changes to the code in the planning tests. It breaks down some long lines of code into multiple lines for better readability, removes an extra blank line, and fixes the indentation of some assert statements. These changes do not affect the functionality or logic of the tests, but improve the code quality and style.
This commit changes the way function manual strings are generated by the FunctionViewExtensions class. It adds indentation and line breaks to make the output more readable and consistent. It also fixes a typo in the default value string and adds a constant for the tab character.
his commit adds several new features and examples to the C# kernel syntax project, which demonstrates how to use the WriterSkill functions and the planning framework in C#. The main changes are: - A new skill, MiscSkill, that provides some utility functions for working with lists and strings. This skill is used in the book sample to extract the chapter synopses from the novel outline. - A new example of creating and executing a book creation plan, which uses the WriterSkill functions and the planning.BucketOutputs function to generate a novel with chapters, themes, and synopses. - A new chapter for the Thinking Caps story, a mystery novel that is generated by the book creation plan. The new chapter introduces the main plot of the case of the missing mascot, and shows the characters' skills, personalities, and teamwork. - A new skill for getting an element from an array at a specified index. This skill has a config.json file and a skprompt.txt file that define the input parameters and the prompt for the skill. The skill returns the element or an error message. - Some minor fixes and improvements to the existing examples, such as fixing a typo in the email plan example, and removing the redundant output of the previous examples.
This commit changes the ToPlanFromXml method to accept a goal string as a parameter, instead of parsing it from the xml string. This simplifies the xml format and avoids duplication of the goal in the plan string. The SequentialPlanner class is also updated to pass the goal to the ToPlanFromXml method. The unit tests and integration tests are modified accordingly to reflect the new xml format.
lemillermicrosoft
force-pushed
the
425_plan_buckets_functionview
branch
from
022c7b6
to
b1794fb
Compare
shawncal
approved these changes
Apr 26, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Minor cleanup of planning components and examples. ### Description This commit changes the way function manual strings are generated by the FunctionViewExtensions class. It adds indentation and line breaks to make the output more readable and consistent. It also fixes a typo in the default value string and adds a constant for the tab character. This commit changes the ToPlanFromXml method to accept a goal string as a parameter, instead of parsing it from the xml string. This simplifies the xml format and avoids duplication of the goal in the plan string.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Minor cleanup of planning components and examples. ### Description This commit changes the way function manual strings are generated by the FunctionViewExtensions class. It adds indentation and line breaks to make the output more readable and consistent. It also fixes a typo in the default value string and adds a constant for the tab character. This commit changes the ToPlanFromXml method to accept a goal string as a parameter, instead of parsing it from the xml string. This simplifies the xml format and avoids duplication of the goal in the plan string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Minor cleanup of planning components and examples.
Description
This commit changes the way function manual strings are generated by the FunctionViewExtensions class. It adds indentation and line breaks to make the output more readable and consistent. It also fixes a typo in the default value string and adds a constant for the tab character.
This commit changes the ToPlanFromXml method to accept a goal string as a parameter, instead of parsing it from the xml string. This simplifies the xml format and avoids duplication of the goal in the plan string.
Contribution Checklist
dotnet format