Make Exception<T> base class non-generic and clean up derived types #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
stephentoub
force-pushed
the
baseexception
branch
from
3640f38
to
b406de6
Compare
shawncal
approved these changes
Apr 27, 2023
lemillermicrosoft
approved these changes
Apr 27, 2023
| /// <param name="message">A string that describes the error.</param> | ||
| /// <param name="detail">A string that provides additional details about the error.</param> | ||
| public AIException(ErrorCodes errorCode, string? message, string? detail) | ||
| : this(errorCode, message, detail: null, innerException: null) |
5 tasks
lemillermicrosoft
added a commit
that referenced
this pull request
Apr 28, 2023
The AIException constructor that takes an errorCode, a message, and a detail was incorrectly passing null as the detail parameter to the base constructor. This commit fixes this bug by passing the detail parameter correctly. This ensures that the detail information is preserved and available for error handling. ### Motivation and Context Bug Introduced: #701 Bug Hidden by: #596
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
The AIException constructor that takes an errorCode, a message, and a detail was incorrectly passing null as the detail parameter to the base constructor. This commit fixes this bug by passing the detail parameter correctly. This ensures that the detail information is preserved and available for error handling. ### Motivation and Context Bug Introduced: #701 Bug Hidden by: #596
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…icrosoft#701) ### Motivation and Context Fixes microsoft#573 ### Description - Make the base class non-generic and rename it to SKException - Remove unnecessary private ctors from derived types - Clean up how messages are generated
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
The AIException constructor that takes an errorCode, a message, and a detail was incorrectly passing null as the detail parameter to the base constructor. This commit fixes this bug by passing the detail parameter correctly. This ensures that the detail information is preserved and available for error handling. ### Motivation and Context Bug Introduced: microsoft#701 Bug Hidden by: microsoft#596
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #573
Description
Contribution Checklist
dotnet format