Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️Fix a bug in AIException constructor #717

Merged
merged 2 commits into from Apr 28, 2023

Conversation

lemillermicrosoft
Copy link
Member

The AIException constructor that takes an errorCode, a message, and a detail was incorrectly passing null as the detail parameter to the base constructor. This commit fixes this bug by passing the detail parameter correctly. This ensures that the detail information is preserved and available for error handling.

Motivation and Context

Bug Introduced: #701
Bug Hidden by: #596

Description

Contribution Checklist

The AIException constructor that takes an errorCode, a message, and a detail was incorrectly passing null as the detail parameter to the base constructor. This commit fixes this bug by passing the detail parameter correctly. This ensures that the detail information is preserved and available for error handling.
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 28, 2023
@lemillermicrosoft lemillermicrosoft added the PR: ready for review All feedback addressed, ready for reviews label Apr 28, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) April 28, 2023 13:44
@lemillermicrosoft lemillermicrosoft merged commit e74274e into microsoft:main Apr 28, 2023
11 checks passed
dluc pushed a commit that referenced this pull request Apr 29, 2023
The AIException constructor that takes an errorCode, a message, and a
detail was incorrectly passing null as the detail parameter to the base
constructor. This commit fixes this bug by passing the detail parameter
correctly. This ensures that the detail information is preserved and
available for error handling.

### Motivation and Context
Bug Introduced: #701
Bug Hidden by: #596
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
The AIException constructor that takes an errorCode, a message, and a
detail was incorrectly passing null as the detail parameter to the base
constructor. This commit fixes this bug by passing the detail parameter
correctly. This ensures that the detail information is preserved and
available for error handling.

### Motivation and Context
Bug Introduced: microsoft#701
Bug Hidden by: microsoft#596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants