Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Keychain request prompts for "M" (or similar) #22385

Closed
Charles-Gagnon opened this issue Nov 4, 2021 · 2 comments · Fixed by microsoft/sqltoolsservice#1939
Closed

MacOS Keychain request prompts for "M" (or similar) #22385

Charles-Gagnon opened this issue Nov 4, 2021 · 2 comments · Fixed by microsoft/sqltoolsservice#1939
Assignees
Labels
Area - Connection Bug Pri: 2 Size: S For a small complexity issue - only when fixed with a PR Triage: Done

Comments

@Charles-Gagnon
Copy link
Contributor

image

We should investigate why this is being listed as a single letter which isn't really helpful for understanding what STS is trying to access. Ideally it would have a more friendly name like "Connection Passwords" or similar.

@ttilberg
Copy link

This prompt has seemingly coming up a lot more frequently. The first few times I saw it, I did not trust it because of the nature of the ambiguous message (Confidential information stored in a or M).

Additionally when you browse through the keychain window, all my other listings appropriately identify themselves.

@stuartpa
Copy link

The credential is appearing to be named a single letter because SqlToolsService is writing the credential as UTF16 characters, so the M is the first character in the name which starts 'M i c r o s o f t'. The same issue exists with the secret, which means the secret cannot be displayed (or updated) with the Keychain UI (it also displays just the first character,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Connection Bug Pri: 2 Size: S For a small complexity issue - only when fixed with a PR Triage: Done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants