Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests ReadToEndForXmlJson and ReadToEndSuccess have random failure #746

Closed
ranasaria opened this issue Nov 22, 2018 · 0 comments
Closed

tests ReadToEndForXmlJson and ReadToEndSuccess have random failure #746

ranasaria opened this issue Nov 22, 2018 · 0 comments

Comments

@ranasaria
Copy link
Contributor

The resultsset tests ReadToEndForXmlJson and ReadToEndSuccess fail randomly when all tests are run but pass when the run alone. Temporarily disabling the tests.
@ranasaria ranasaria mentioned this issue Dec 4, 2018
Merged
ranasaria added a commit that referenced this issue Dec 5, 2018
@ranasaria
Feat/result streaming - Fix for issue #746 in toolsservice and issue m…
e4808c1 
…icrosoft/azuredatastudio#3348 (#753)

* fix for issues 746 & azuredatastudio issue 3348

* test coverage improvement for results streaming

* addressed minor review comments

* adding generated file test/CodeCoverage/package-lock.json to workaround code coverage issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranasaria